ci: save build artifacts #255
Conversation
b9a9003 to
935f67c
Compare
There was a problem hiding this comment.
Are you satisfied with your saving ?
Of course, the best would be a dmg file, but that's maybe a too big task.
Btw, I do my changes on my fork, and when I'm done I create a pull request on upstream to avoid noise for others. Ok, this is not always helping... but I try
| xcodebuild -workspace GitX.xcworkspace -scheme GitX -archivePath ./GitX archive | ||
| tar -acf GitX.xcarchive.zip GitX.xcarchive | ||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
What's about to avoid size by skipping failed jobs ?
https://github.com/hannesa2/mediapipe/blob/APK-0.8.2/.github/workflows/CI.yml#L44
I mean similar with
if: ${{ success() }}
There was a problem hiding this comment.
OK, I had assumed that, if the build failed, follow up jobs would be cancelled. This is nice and clear, though.
|
To be honest, I'm not that familiar with the archived file, and I was not able to use. When you write, that you can use your generated artifacts, I will merge it immediate |
|
It’s a special directory, like GitX.app. You can right click, then “show package contents”. That should open it in Finder. It’s the first time I’ve ever dealt with a .xcarchive too.
And Sorry about the spam! This was my first time with GitHub ci and I didn’t realize how to get it to run without pushing to a PR.
|
fa427e4 to
3a4825a
Compare
|
Ok, the latest version includes the Regarding all of the artifacts: if each build uses the same artifact name, then we will end up w/ only a single artifact from whatever build completed last. (Each one will be overwritten.) Another option would be to do something like |
3a4825a to
811a4ee
Compare
I was wrong. There is something about the |
|
fyi: I was able to generate an archive in my fork using this pull request, download and unzip the archive and then pull a working app out of |
|
I merge it and when you have a beeter solution
Fine, I will merge it and when you have a better solution : please share with us |
No problem, I will squash all |
|
I just opened #256, which updates CI to upload a dmg instead of an xcarchive. |
This saves
.xcarchivebuild artifacts, which include the prebuilt binaries for each CI run. This is my first time using Github Actions, so any pointers or advice are very welcome. After downloading and extracting,GitX.appis located atGitX.xcarhive/Products/Applications/GitX.appThis is based on:
(The latter 2 based @hannesa2's comment in #240 (comment))
I followed UTMs lead and zipped the
.xcarchivein CI, which I assume is just easier/faster for CI to deal with. However, when downloading artifacts, it zips them again, so the downloaded file is a zip that contains a zip that itself contains theGitX.xcarchivedir/package. We could skip the tar/zip step in CI, which would result in the download just being a zip that contains the.xcarchive, but I don't know if that would slow down CI or anything for having to deal w/ uploading all of the files individually. Opinions?These are not "releases", they are just artifacts. As such, they will only be retained for 90 days (the default and max allowed for public repos). If someone wants to take this and run w/ it to make it more of a nightly release mechanism, please have at it.
This doesn't fix the local build issues that many of us seem to be having (see #239), but it at least allows us to use whatever black magic is happening in CI to access a recent build.
See #240 #221 #239 and generally any other error w/ a title like "build failure" or "cannot build".