-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(rules): Add 1Password secret key detection #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty high confidence. :O
Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
Thanks for this feedback, @rgmz! I've made these changes. The tests failed due to I ran for i in $(seq 100); do go generate ./... ; done And it only generated a |
After running some simulations I found that |
ty @jrdnbradford @rgmz. This looks solid to me |
* Add `1password-secret-key` detection * Document key details * Update cmd/generate/config/rules/1password.go Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com> * Generate new `.toml` * Use `GenerateSampleSecrets` to test more scenarios * Comment lowercase `fps` * Decrease entropy --------- Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
Description:
Closes #1813 by adding support for detecting 1Password secret keys.
Checklist: