Percent/URL Decoding Support #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bef24cd to
7a0d3f5
Compare
zricethezav
reviewed
Apr 21, 2025
zricethezav
reviewed
Apr 21, 2025
7e1eefd to
5ebf6a7
Compare
b4ddd81 to
b62dba3
Compare
bplaxco
commented
May 9, 2025
zricethezav
approved these changes
May 12, 2025
There was a problem hiding this comment.
At this point I'm convinced @bplaxco is some kind of wizard or time traveling AI
zricethezav
reviewed
May 12, 2025
| } | ||
|
|
||
| segments = append(segments, segment) | ||
| logging.Debug().Msgf( |
There was a problem hiding this comment.
love this debug message
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* Add initial percent decoding support * Refactor multi encoding support * Add detect tests to confirm positions * Avoid a few extra passes during decoding * Do multiple passes for finding encodings re * Fix issue with overlapping encodings when doing separate passes
rgmz
reviewed
Aug 28, 2025
Comment on lines
+28
to
+30
| if err == nil && isPrintableASCII(decodedValue) { | ||
| return string(decodedValue) | ||
| } |
There was a problem hiding this comment.
@bplaxco Hypothetically, couldn't there be chunks that have both standard and url encoding? I guess since this is recursive it should catch both cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add percent decoding (aka URL decoding) support.
Goals:
[1]: For example:
This
aGVsbG8sIHdvcmxkIQ%3D%3D%0Ashould decode first toaGVsbG8sIHdvcmxkIQ==and thenhello, world!. But this'hello%2C%20world%21 aGVsbG8sIHdvcmxkIQ==shouldn't need two passes to to be fully decoded.TODO
detect_test.go(make sure to test multiple levels and that the parent child relationship works properly with segments)Checklist: