Skip to content

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Apr 8, 2025

Description:

This makes the following changes:

  • Call Rule.Validate and Allowlist.Validate when generating the config
  • Sort the allowlist stopwords so the output is deterministic (this seems to require *Allowlist)

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@rgmz rgmz force-pushed the feat/allowlist-constructor branch 2 times, most recently from efe1c00 to 5fbb771 Compare April 8, 2025 21:16
@rgmz rgmz marked this pull request as ready for review April 8, 2025 21:17
@rgmz rgmz force-pushed the feat/allowlist-constructor branch 5 times, most recently from c0afbcc to aa6537c Compare April 9, 2025 01:00
@rgmz rgmz force-pushed the feat/allowlist-constructor branch from aa6537c to f5ffffd Compare April 9, 2025 01:48
@zricethezav
Copy link
Collaborator

lgtm, thanks!

@zricethezav zricethezav merged commit cfdeb0d into gitleaks:master Apr 12, 2025
2 checks passed
@rgmz rgmz deleted the feat/allowlist-constructor branch April 12, 2025 15:10
rgmz added a commit to rgmz/gitleaks that referenced this pull request Apr 13, 2025
sirakav pushed a commit to sirakav/gitleaks that referenced this pull request Apr 25, 2025
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants