Added Heroku API Key New Version #1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
approved these changes
Jun 4, 2025
cmd/generate/config/rules/heroku.go
Outdated
Comment on lines
33
to
34
| Regex: utils.GenerateUniqueTokenRegex(`\b(HRKU-AA[0-9a-zA-Z_-]{58})\b`, true), | ||
| Keywords: []string{"HRKU-AA"}, |
There was a problem hiding this comment.
A few observations:
- Using
\bisn't required in conjunction withGenerateUniqueTokenRegex. Also,\bis never valid beside a character like-, on[a-zA-Z0-9_]. GenerateUniqueTokenRegexalso take scare of capture groups, so they don't have to be manually defined.- The second parameter should be
false, otherwise it marks the entire regex as case-insensitive which makes it possible to match invalid strings (hrku-aa). - A rule should almost always have a minimum entropy threshold.
Suggested change
| Regex: utils.GenerateUniqueTokenRegex(`\b(HRKU-AA[0-9a-zA-Z_-]{58})\b`, true), | |
| Keywords: []string{"HRKU-AA"}, | |
| Regex: utils.GenerateUniqueTokenRegex(`HRKU-AA[0-9a-zA-Z_-]{58}`, false), | |
| Entropy: 4, | |
| Keywords: []string{"HRKU-AA"}, |
|
nice, thanks @kashifkhan0771 and @rgmz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Heroku API Keys Pattern is updated.
Checklist: