Skip to content

Fix rule-specific allowlist paths not working #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix rule-specific allowlist paths not working #1845

merged 1 commit into from
Apr 30, 2025

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Apr 30, 2025 •
edited
Loading

Description:

Fixes #1844. Doing return caused the function to potentially exit before testing all allowlists. An oversight on my part.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav
Copy link
Collaborator

excellent catch. ty for test

@zricethezav zricethezav merged commit d1c7759 into gitleaks:master Apr 30, 2025
2 checks passed
@rgmz rgmz deleted the fix/allowlist-path-eval branch April 30, 2025 15:40
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
@rgmz
fix(detect): test all allowlists (gitleaks#1845)
edca1c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule-specific allowlist paths not working with extend useDefault = true
2 participants
@rgmz @zricethezav