added sourcegraph token rule #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
suggested changes
Jan 29, 2025
| } | ||
|
|
||
| // validate | ||
| tps := utils.GenerateSampleSecrets("sgp_", secrets.NewSecret(`\b(sgp_(?:[a-fA-F0-9]{16}|local)_[a-fA-F0-9]{40}|sgp_[a-fA-F0-9]{40}|[a-fA-F0-9]{40})\b`)) |
There was a problem hiding this comment.
We should add separate test cases for each pattern. This will only generate cases for a single pattern, meaning obvious issues could be missed.
Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
|
very nice! Thanks @kashifkhan0771 |
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* added sourcegraph token rule * updated ruleid Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com> * added more true positive test cases --------- Co-authored-by: Richard Gomez <32133502+rgmz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR add a new rule for sourcegraph tokens.
Issue: #1697
Checklist: