Skip to content

Conversation

thomas-nilsson-irfu
Copy link
Contributor

@thomas-nilsson-irfu thomas-nilsson-irfu commented Mar 13, 2025

As described in issue #1791, the https://hooks.slack.com/triggers/ secrets should perhaps also be detected.

Reference
https://slack.com/help/articles/360041352714-Build-a-workflow--Create-a-workflow-that-starts-outside-of-Slack

Feel free to use, change any part of this proposed fix, or to simply discard it.

(ps. I did a minor typo in a comment in issue 1791, proposing this change but that was corrected here. ds.)

Description:

Explain the purpose of the PR.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

As described in issue 1791, the hooks.slack.com/triggers should perhaps
also be detected.

Reference
https://slack.com/help/articles/360041352714-Build-a-workflow--Create-a-workflow-that-starts-outside-of-Slack

Feel free to use, change any part of this proposed fix, or to simply
discard it.

(ps. I did a minor typo in a comment in issue 1791, proposing this
change but that was corrected here. ds.)
@zricethezav
Copy link
Collaborator

nailed it! Thanks @thomas-nilsson-irfu

@zricethezav zricethezav merged commit 9708e65 into gitleaks:master Mar 27, 2025
2 checks passed
sirakav pushed a commit to sirakav/gitleaks that referenced this pull request Apr 25, 2025
As described in issue 1791, the hooks.slack.com/triggers should perhaps
also be detected.

Reference
https://slack.com/help/articles/360041352714-Build-a-workflow--Create-a-workflow-that-starts-outside-of-Slack

Feel free to use, change any part of this proposed fix, or to simply
discard it.

(ps. I did a minor typo in a comment in issue 1791, proposing this
change but that was corrected here. ds.)
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
As described in issue 1791, the hooks.slack.com/triggers should perhaps
also be detected.

Reference
https://slack.com/help/articles/360041352714-Build-a-workflow--Create-a-workflow-that-starts-outside-of-Slack

Feel free to use, change any part of this proposed fix, or to simply
discard it.

(ps. I did a minor typo in a comment in issue 1791, proposing this
change but that was corrected here. ds.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants