Prevent Yocto/BitBake false positives with generic-api-key rule #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chCondition https://pkg.go.dev/text/template#hdr-Actions > {{with pipeline}} T1 {{end}} > If the value of the pipeline is empty, no output is generated; > otherwise, dot is set to the value of the pipeline and T1 is > executed. Within the `with` block `.MatchCondition` is implicit and must be omitted to work. The fault/bug was not triggered before because this is the first non-default MatchCondition apparently.
zricethezav
reviewed
Mar 11, 2025
| [[rules.allowlists]] | ||
| condition = "AND" | ||
| paths = [ | ||
| '''\.bb$''','''\.bbappend$''','''\.bbclass$''','''\.inc$''', |
There was a problem hiding this comment.
outside of the scope for this PR but it would be nice if this formatting matched the other toml arrays where each line has an entry
|
nice work @Okeanos! Thanks for this PR |
sirakav
pushed a commit
to sirakav/gitleaks
that referenced
this pull request
Apr 25, 2025
…eaks#1783) * fix: make config template work when providing non-iota values for MatchCondition https://pkg.go.dev/text/template#hdr-Actions > {{with pipeline}} T1 {{end}} > If the value of the pipeline is empty, no output is generated; > otherwise, dot is set to the value of the pipeline and T1 is > executed. Within the `with` block `.MatchCondition` is implicit and must be omitted to work. The fault/bug was not triggered before because this is the first non-default MatchCondition apparently. * feat: exclude false positive matches for Yocto/Bitbake from generic-api-key rule Fixes gitleaks#1775
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
…eaks#1783) * fix: make config template work when providing non-iota values for MatchCondition https://pkg.go.dev/text/template#hdr-Actions > {{with pipeline}} T1 {{end}} > If the value of the pipeline is empty, no output is generated; > otherwise, dot is set to the value of the pipeline and T1 is > executed. Within the `with` block `.MatchCondition` is implicit and must be omitted to work. The fault/bug was not triggered before because this is the first non-default MatchCondition apparently. * feat: exclude false positive matches for Yocto/Bitbake from generic-api-key rule Fixes gitleaks#1775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements exceptions to the generic-api-key rule to prevent false positives experienced with Yocto/BitBake projects as explained in #1775
Checklist: