Add MaxMind license key rule #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zricethezav
reviewed
Mar 28, 2025
zricethezav
reviewed
Mar 28, 2025
cmd/generate/config/rules/maxmind.go
Outdated
| RuleID: "maxmind-license-key", | ||
| Description: "Discovered a potential MaxMind license key.", | ||
| Regex: utils.GenerateUniqueTokenRegex(`[A-Za-z0-9]{6}_[A-Za-z0-9]{29}_mmk`, false), | ||
| Keywords: []string{"mmk"}, |
There was a problem hiding this comment.
Let's add an entropy filter as well. How about a threshold of 4?
|
Hey @mmpnelson, thanks for the PR! Got a few suggestions. Also if you want to play around with the rules in a playground in browser I loaded up the maxmind rule here: |
|
Great, thanks! How does this look? |
zricethezav
approved these changes
Mar 29, 2025
sirakav
pushed a commit
to sirakav/gitleaks
that referenced
this pull request
Apr 25, 2025
* Add MaxMind license key rule * Address review feedback for MaxMind license key rule
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* Add MaxMind license key rule * Address review feedback for MaxMind license key rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add MaxMind license key rule
Checklist: