Make AddFinding public #1767
Merged
Make AddFinding public #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename d.addFindings -> d.AddFindings - Add d.Findings() To allow other tools using d.Detect() to leverage the code in AddFindings
zricethezav
approved these changes
Feb 24, 2025
sirakav
pushed a commit
to sirakav/gitleaks
that referenced
this pull request
Apr 25, 2025
- Rename d.addFindings -> d.AddFindings - Add d.Findings() To allow other tools using d.Detect() to leverage the code in AddFindings
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
- Rename d.addFindings -> d.AddFindings - Add d.Findings() To allow other tools using d.Detect() to leverage the code in AddFindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To allow other tools using d.Detect() to leverage the code in AddFinding
Changes:
My use case: https://github.com/leaktk/scanner/pull/107/files#diff-f8472fe0bafccc33f268c74d1bd2a697594914d4e1d796805b254249cbc78828R175-R182
Checklist:
Have you written new tests for your changes?(N/A)cc: @zricethezav && @rgmz