Make paths and fingerprints platform-agnostic #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
697b436 to
59a5e12
Compare
59a5e12 to
b074b3f
Compare
|
I ran this on windows and as far as I could tell, it works well. The unit test TestFromFiles now also passes on windows. (some other unit tests still fail on windows for reasons entirely unrelated to this pull request, e.g. symlinks and deletion of temp files) |
b074b3f to
498034f
Compare
082fc96 to
4053c9a
Compare
710104b to
6fbc170
Compare
4d1dac7 to
9d3555e
Compare
9d3555e to
c206912
Compare
|
@zricethezav it's a bit awkward but I believe this is now fully backwards-compatible.
|
a574ad7 to
260f42d
Compare
260f42d to
ef7216f
Compare
ef7216f to
5c71c5b
Compare
zricethezav
reviewed
Feb 20, 2025
| @@ -49,6 +49,7 @@ func TestWriteSarif(t *testing.T) { | |||
| t.Run(test.cfgName, func(t *testing.T) { | |||
| tmpfile, err := os.Create(filepath.Join(t.TempDir(), test.testReportName+".json")) | |||
| require.NoError(t, err) | |||
| defer tmpfile.Close() | |||
There was a problem hiding this comment.
whoops, thanks for adding this in
There was a problem hiding this comment.
Surprisingly, this didn't seem to cause trouble on *nix. It was only a consistent issue on Windows.
this change also fixes, or skips, windows failures
5c71c5b to
0a4ef20
Compare
|
great work! |
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* test: windows * fix: make paths platform-agnostic this change also fixes, or skips, windows failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes #1565.
Note: the current 'fix' is technically a breaking change forpath/pathsregular expressions as mentioned here. I don't know if this is acceptable, or what the best way to handle this would be. (Test both styles of paths ifruntime.GOOS == 'Windows'?)TODO
rule.pathandrule.allowlist.pathsregexes on WindowsChecklist: