Skip to content

Fix inconsistent generated values in config #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix inconsistent generated values in config #1200

merged 1 commit into from
Jun 16, 2023

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Jun 16, 2023

Description:

There are some changes that keep getting overwritten when generating a config, namely:

diff --git a/config/gitleaks.toml b/config/gitleaks.toml
index 77fd1e4..c8babf4 100644
--- a/config/gitleaks.toml
+++ b/config/gitleaks.toml
@@ -14,7 +14,7 @@ title = "gitleaks config"
 description = "global allow lists"
 paths = [
     '''gitleaks.toml''',
-    '''(.*?)(jpg|gif|doc|docx|zip|xls|pdf|bin|svg|socket|vsidx|v2|suo|wsuo|.dll|pdb|exe)$''',
+    '''(.*?)(jpg|gif|doc|docx|zip|xls|pdf|bin|svg|socket)$''',
     '''(go.mod|go.sum)$''',
     '''gradle.lockfile''',
     '''node_modules''',
@@ -2386,7 +2386,7 @@ id = "openai-api-key"
 regex = '''(?i)\b(sk-[a-zA-Z0-9]{20}T3BlbkFJ[a-zA-Z0-9]{20})(?:['|\"|\n|\r|\s|\x60|;]|$)'''
 secretGroup = 1
 keywords = [
-    "sk-","t3blbkfj",
+    "t3blbkfj",
 ]

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@rgmz rgmz mentioned this pull request Jun 16, 2023
Merged
3 tasks
@zricethezav zricethezav merged commit 06db3b9 into gitleaks:master Jun 16, 2023
@zricethezav
Copy link
Collaborator

Thanks for the cleanup @rgmz

@rgmz rgmz deleted the chore/config-values branch June 16, 2023 16:28
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
@rgmz
chore(config): fix inconsistent generated values (gitleaks#1200)
604bef7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @zricethezav