1079 #1291
Open
1079 #1291
+689
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Nov 17, 2023
Comment on lines
+39
to
+57
| func AzureStorageCredential86char() *config.Rule { | ||
| // define rule | ||
| r := config.Rule{ | ||
| Description: "CSCAN0030, CSCAN0090, CSCAN0150 - Found Azure storage credential in source code file.", | ||
| RuleID: "azure-storage-credential-86char", | ||
| SecretGroup: 1, | ||
| Regex: generateUniqueTokenRegex(`[ \t]{0,10}[a-zA-Z0-9/+]{86}==`, true), | ||
| Keywords: []string{"=="}, | ||
| } | ||
|
|
||
| // validate | ||
| tps := []string{ | ||
| generateSampleSecret("azure-storage-credential-86char", | ||
| secrets.NewSecret(alphaNumeric("86")+"==")), | ||
| } | ||
| return validate(r, tps, nil) | ||
| } | ||
|
|
||
| func AzureStorageCredential43char() *config.Rule { |
There was a problem hiding this comment.
I've tested both these out and they're far too noisy as-is. I'm not sure how they can be improved beyond adding a prefix for "accountkey", though that may overlap with an existing pattern.
|
Down the bottom of this link you see the keywords that Microsoft
recommends. So perhaps we could get at least partial coverage even if we
don't use accountkey itself? I think these two rules are probably two of
the highest value rules in the Azure set so at least some effort to include
them is likely worthwhile in my opinion. Let me know what you think?
https://learn.microsoft.com/en-us/purview/sit-defn-azure-storage-account-access-key
Edit: apologies, didn't realise that email reply would create a separate comment instead of just replying to the review @rgmz
…On Fri, 17 Nov 2023, 15:15 Richard Gomez, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/generate/config/rules/azure.go
<#1291 (comment)>:
> +func AzureStorageCredential86char() *config.Rule {
+ // define rule
+ r := config.Rule{
+ Description: "CSCAN0030, CSCAN0090, CSCAN0150 - Found Azure storage credential in source code file.",
+ RuleID: "azure-storage-credential-86char",
+ SecretGroup: 1,
+ Regex: generateUniqueTokenRegex(`[ \t]{0,10}[a-zA-Z0-9/+]{86}==`, true),
+ Keywords: []string{"=="},
+ }
+
+ // validate
+ tps := []string{
+ generateSampleSecret("azure-storage-credential-86char",
+ secrets.NewSecret(alphaNumeric("86")+"==")),
+ }
+ return validate(r, tps, nil)
+}
+
+func AzureStorageCredential43char() *config.Rule {
I've tested both these out and they're far too noisy as-is. I'm not sure
how they can be improved beyond adding a prefix for "accountkey", though
that may overlap with an existing pattern.
—
Reply to this email directly, view it on GitHub
<#1291 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFQOPRHTNRLWV3ANP2GICLYE3XH7AVCNFSM6AAAAAA7O64O4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZWGA2TONJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #539 - adds Azure rules
Checklist: