Add makefile variable detections #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayne-snyk
commented
Jun 9, 2023
| @@ -19,7 +19,7 @@ const ( | |||
| identifierSuffix = `)(?:[0-9a-z\-_\t .]{0,20})(?:[\s|']|[\s|"]){0,3}` | |||
|
|
|||
| // commonly used assignment operators or function call | |||
| operator = `(?:=|>|:=|\|\|:|<=|=>|:)` | |||
| operator = `(?:=|>|:{1,3}=|\|\|:|<=|=>|:|\?=)` | |||
There was a problem hiding this comment.
This could also be (?:=|>|:+=|\|\|:|<=|=>|:|\?=) for a bit more flexibility with the colons. Let me know if you prefer this to {1,3}.
There was a problem hiding this comment.
operator = `(?:=|>|:{1,3}=|\|\|:|<=|=>|:|\?=)`
is good with me
alayne222
pushed a commit
to alayne222/gitleaks
that referenced
this pull request
May 28, 2025
* add makefile variable definitions * update snyk tests * regenerate config
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds makefile variable detections by updating the base regex used by
generateSemiGenericRegex.The regenerated config is a sizable diff since this is how many of the regex detections are created.
Checklist: