Skip to content

Go linter errors? #741

@zmoazeni

Description

@zmoazeni

Hiya! One of the nice features of Visual Studio Code is that it integrates linters very easily.

Unfortunately, checking a few different linters comes up with a slew of issues in this codebase. I've moved to golangci-lint because it's one of the few that supports Go modules.

Here's a snippet of the issues I'm seeing:

2019-05-17_13-31

Some questions I have:

  1. Should we resolve these? If so, what would be the best way to PR these changes?
  2. Should we add the linter(s) to CI to prevent getting into the same scenario in the future?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions