Skip to content

HTTP throttler has no timeout #1130

@timvaillancourt

Description

@timvaillancourt

gh-ost currently does not pass a timeout or context to the HTTP client in go/logic/throttler.go

The lack of a timeout can theoretically cause the ticker-loop in .collectThrottleHTTPStatus() to block for a response indefinitely

Passing a context.Context to the net/http client will allow slow calls to an HTTP throttler service (eg: github/freno) to timeout instead of block the loop. A PR is on the way 👍

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions