Skip to content

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 5, 2020

Proposed changes

  • Decouple script parsing from the revision grid. This will allow easier and simpler integration of other controls with the script manager (e.g. the left panel or the file tree)
  • Extract user script binding to a context menu to an extension method. This will allow re-use of the functionality in other parts of the app (e.g. the left panel or the file tree). This is small step in the same direction as WIP: Add 'Run script' command to branches pane context menu #6348 proposed by @IvanGreK. Sadly we stalled on this work.
  • Review the code and add multiple validations and add tests.

This work is foundational to allow re-use of user scripts in other parts of the app (e.g. the left panel or the file tree). Specifically I want to allow users to run custom scripts for files in the working tree, e.g. to achieve what was proposed in #6135, or open a file and/or folder in VS Code, or launch a project in a VS.

image


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned RussKie Apr 5, 2020
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK wit a few nit questions, not run it

@RussKie RussKie force-pushed the Uplift_script_handling branch from ebbfc92 to 9dc20c3 Compare April 10, 2020 12:38
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RussKie RussKie force-pushed the Uplift_script_handling branch from f53b37a to a789d4c Compare April 12, 2020 12:00
@RussKie RussKie force-pushed the Uplift_script_handling branch from a789d4c to 4e85cbc Compare April 12, 2020 12:25
@RussKie RussKie merged commit 1f68594 into gitextensions:master Apr 12, 2020
@RussKie RussKie deleted the Uplift_script_handling branch April 12, 2020 12:40
@ghost ghost added this to the 4.0 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants