WIP: POC for removing useless curves in revision graph #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5783 +/- ##
==========================================
- Coverage 36.94% 36.93% -0.01%
==========================================
Files 620 620
Lines 47416 47436 +20
Branches 6323 6330 +7
==========================================
+ Hits 17518 17522 +4
- Misses 29115 29132 +17
+ Partials 783 782 -1 |
2c8de70 to
1e51ebc
Compare
drewnoakes
reviewed
Nov 18, 2018
| } | ||
| // Anti-aliasing with bezier & PixelOffsetMode.HighQuality | ||
| // introduces an offset of ~1/8 px - compensate it. | ||
| g.SmoothingMode = SmoothingMode.AntiAlias; |
There was a problem hiding this comment.
The comment still exists, but I don't see the 1/8px offset in code.
drewnoakes
reviewed
Nov 18, 2018
| { | ||
| // Anti-aliasing with bezier & PixelOffsetMode.HighQuality | ||
| // introduces an offset of ~1/8 px - compensate it. | ||
| g.SmoothingMode = SmoothingMode.AntiAlias; |
1e51ebc to
01b8c8f
Compare
|
Thank you, the graph looks much clearer now! Two little things could be improved yet.
|
01b8c8f to
5786eea
Compare
|
@spdr870 |
|
This is an old PR and should be closed or set to a draft. @gerhardol |
|
Several of the changes in this PR has been included in PRs by @mstv. Can you summarize if something is not included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5782
Changes proposed in this pull request:
First commit, remove the not-needed curves:
Second commit, make the lines more smooth:
What did I do to test the code and ensure quality:
Has been tested on (remove any that don't apply):