Fix FormRemotes color label size #12305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Apr 6, 2025
| @@ -113,6 +113,9 @@ public FormRemotes(IGitUICommands commands) | |||
| // Set the minimum height of the color button to be the same as the reset button | |||
| btnRemoteColor.MinimumSize = new Size(DpiUtil.Scale(60), btnRemoteColorReset.Height); | |||
|
|
|||
| // Prevent btnRemoteColorReset from blinking out soon after form loads | |||
| btnRemoteColorReset.Visible = false; | |||
There was a problem hiding this comment.
Set in the designer file please.
There was a problem hiding this comment.
The reason it wasn't set in a designer is that a few lines above its height is used to set MinimumSize of btnRemoteColor and if it's invisible during component initialization it has a wrong height.
I've changed the MinimumSize calculation of btnRemoteColor to use its own height as this is before index change event happens and this button's props are changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12303
Proposed changes
AutoSize = truefor labelsbtnRemoteColorResetfrom blinking out part of a second after being shownScreenshots
Before
At 200%
After
At 200%
At 100%
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.