Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Mar 29, 2025

Fixes #12278

Proposed changes

  • Go to current line
  • Ask for retry on RPC_E_CALL_REJECTED

Screenshots

Before

exception popup

After

image

Test methodology

  • manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Mar 29, 2025
@gerhardol
Copy link
Member

Goto line works well unless the file is a winforms designer file, then I get a popup:

image

That the Winforms designer is opened by default is why I hardly use this feature (only use MSVS with GE).

@mstv
Copy link
Member Author

mstv commented Mar 30, 2025

Goto line works well unless the file is a winforms designer file, then I get a popup:

image

I am adding a catch.

That the Winforms designer is opened by default is why I hardly use this feature (only use MSVS with GE).

@pmiossec gave this very useful hint:

image

@pmiossec
Copy link
Member

That the Winforms designer is opened by default is why I hardly use this feature (only use MSVS with GE).
@pmiossec gave this very useful hint:

I don't remember having already given this hint but was about to give it again because it was a mandatory one the days I was doing some wpf (where designer was very slow)... I find it also very satisfying when doing winforms even if with winforms you are more often obliged to use the designer.

Ignore unavailibility of "Edit.GoTo".
gerhardol
gerhardol approved these changes Mar 31, 2025
@mstv mstv merged commit 0878385 into gitextensions:master Mar 31, 2025
3 of 4 checks passed
@mstv mstv deleted the vs_integration branch March 31, 2025 21:19
@mstv mstv added this to the v5.3 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NBug] Call was rejected by callee. (0x80010001...
3 participants