Skip to content

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Mar 24, 2025

Bump most of the dependencies. There are some dependencies which I'm not sure about, so I left those alone.

Whilst building a fresh clone I got a bunch of errors similar to the following:

....csproj : error NU1903: Warning As Error: Package 'System.Text.RegularExpressions' 4.3.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-cmhx-cq75-c4mj

This specific issue was transitively caused by the old verison of NSubstitute we use.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits
needs ad35c81 (I could not push to this PR)

Comment on lines +73 to +76
{
// Both sequences end at the same point. We are finished.
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: arguable indent of not needed { }
(not requesting a change)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was auto formatted by VS...
¯\_(ツ)_/¯

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 mstv to approve when the issues are resolved

@mstv
Copy link
Member

mstv commented Mar 26, 2025

still needs ad35c81 (I could not push to this PR)

@gerhardol
Copy link
Member

With this I cannot create packages.

$ powershell.exe '.\setup\installer\Check-BundlesConsistent.ps1' 'C:\dev\gc\gitextensions_4\artifacts\Release\publish\GitExtensions'
[ERROR] Items not declared in Product.wxs:
C:\dev\gc\gitextensions_4\artifacts\Release\publish\GitExtensions\Testably.Abstractions.FileSystem.Interface.dll

@RussKie
Copy link
Member Author

RussKie commented Mar 28, 2025

Thank you, folks. I'll look into these in the coming days.

@mstv
Copy link
Member

mstv commented Mar 28, 2025

MC resolved and squashed in 8bb1abe.

@RussKie
Copy link
Member Author

RussKie commented Mar 29, 2025

MC resolved and squashed in 8bb1abe.

🙇‍♂️

@RussKie
Copy link
Member Author

RussKie commented Mar 30, 2025

The build is green.

@@ -227,6 +224,9 @@
<Component Id="TestableIO.System.IO.Abstractions.Wrappers.dll" Guid="*">
<File Source="$(var.ArtifactsPublishPath)\TestableIO.System.IO.Abstractions.Wrappers.dll" />
</Component>
<Component Id="Testably.Abstractions.FileSystem.Interface.dll" Guid="*">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do Testably have to be bundled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a "new" dependency of System.IO.Abstractions.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well

@RussKie RussKie merged commit 0ae4f1a into gitextensions:master Mar 31, 2025
3 of 4 checks passed
@RussKie RussKie deleted the bump_deps branch March 31, 2025 20:46
@mstv mstv added this to the v5.3 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants