-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update dependencies #12277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #12277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
needs ad35c81 (I could not push to this PR)
{ | ||
// Both sequences end at the same point. We are finished. | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: arguable indent of not needed { }
(not requesting a change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was auto formatted by VS...
¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2 mstv to approve when the issues are resolved
still needs ad35c81 (I could not push to this PR) |
With this I cannot create packages. $ powershell.exe '.\setup\installer\Check-BundlesConsistent.ps1' 'C:\dev\gc\gitextensions_4\artifacts\Release\publish\GitExtensions' |
Thank you, folks. I'll look into these in the coming days. |
MC resolved and squashed in 8bb1abe. |
🙇♂️ |
The build is green. |
@@ -227,6 +224,9 @@ | |||
<Component Id="TestableIO.System.IO.Abstractions.Wrappers.dll" Guid="*"> | |||
<File Source="$(var.ArtifactsPublishPath)\TestableIO.System.IO.Abstractions.Wrappers.dll" /> | |||
</Component> | |||
<Component Id="Testably.Abstractions.FileSystem.Interface.dll" Guid="*"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do Testably have to be bundled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a "new" dependency of System.IO.Abstractions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well
Bump most of the dependencies. There are some dependencies which I'm not sure about, so I left those alone.
Whilst building a fresh clone I got a bunch of errors similar to the following:
This specific issue was transitively caused by the old verison of NSubstitute we use.