fix: catch plugin settings load exceptions #12219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmiossec
approved these changes
Feb 22, 2025
mstv
reviewed
Feb 22, 2025
| { | ||
| AddSettingControl(setting.CreateControlBinding()); | ||
| throw new Exception($"Cannot load settings for plugin {_gitPlugin?.Name ?? "unknown"}", ex); |
There was a problem hiding this comment.
❔
Suggested change
| throw new Exception($"Cannot load settings for plugin {_gitPlugin?.Name ?? "unknown"}", ex); | |
| throw new ExternalOperationException($"Cannot load settings for plugin {_gitPlugin?.Name ?? "unknown"}", ex); |
There was a problem hiding this comment.
This is not really an external exception, all info is not meaningful:
public ExternalOperationException(
string? command = null,
string? arguments = null,
string? workingDirectory = null,
int? exitCode = null,
Exception? innerException = null)
UserExternalOperationException can be used, but does not make sense either to me.
There was a problem hiding this comment.
The key is that the BugReportReportInvoker presents the ExternalOperationException without "Report bug" as default but with the hint that something external failed - most likely in user's responsibility.
This might be applicable here: A plugin might be outdated.
The arguments are optional. My suggestion was incomplete.
Suggested change
| throw new Exception($"Cannot load settings for plugin {_gitPlugin?.Name ?? "unknown"}", ex); | |
| throw new ExternalOperationException(command: $"Load settings for plugin {_gitPlugin?.Name ?? "unknown"}", innerException: ex); |
There was a problem hiding this comment.
ok
This problem is likely in the bundled plugins or GE core, but no need to alarm users...
(Also keeping Cannot)
mstv
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some info to debug #12212 etc
The most common NBug after Windows update issues and Git reporting errors.
Proposed changes
The exception does not even contain the plugin that fails right now.
More info can be added?
Test methodology
Added throw to see the message appeared.
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.