As a reference, the adapted colors in dark mode

In the dark mode the text should be light, not dark though.

Other than that, the screenshots look good

As a reference, the adapted colors in dark mode

In the dark mode the text should be light, not dark though.

In this PR, the dark mode colors are not adapted, the dark mode colors are very bright, same as in light mode. This is slightly to light to me, but acceptable. It takes forever to adjust all colors.

The "automatic" adaption will try to change the very bright colors close to the white background to dark colors close to the dark mode grayish background. This worked better with the 3.x dark mode as the background was closer to black. It is much harder to adjust colors with the .net9 dark mode, it looks worse and less contrast to play with. (Most dark modes are darker too.)

But custom colors would in this case require theme colors (or that the OtherColors are reversed and the colors are hardcoded again). An example below, also in light mode (not great).

    public static readonly Color BrightGreen = Color.FromArgb(106, 209, 106);
    public static readonly Color BrightYellow = Color.FromArgb(209, 209, 106);
    public static readonly Color BrightRed = Color.FromArgb(209, 106, 106);

All details will not be fixed in #12111, there are too many issues in .net9 implementation anyway, it will be experimental.

My comment isn't blocking, more like thinking out loud. This can certainly be tinkered with later.
Good job.

My comment isn't blocking, more like thinking out loud. This can certainly be tinkered with later. Good job.

If you have comments on the dark mode related to this, lets resolve it here: If the colors need to be adjusted for dark mode, then they must be themeable and that is could be done outside that PR (even if it is not changing light mode it is big anyway).
Dark mode will be experimental in GE (as Winforms could even remove the feature in .net10) and everything will not be perfect.

I just made a private build of your .net9 theming branch, so it'll take me some time to form tangible feedback. But it looks 🔥🔥🔥🔥

In this case it was just feedback for the reset/settings colors in dark mode, if more adjustments are needed.

In this case it was just feedback for the reset/settings colors in dark mode, if more adjustments are needed.

I haven't used it enough to form an opinion. Yet.