Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Feb 3, 2025

Fixes regression from adding a second SplitControl

Proposed changes

OutputHistoryPanelController:

  • Hide Output History Panel with Left Panel (-
  • Show Left Panel on show of Output History Panel

Screenshots

Before

image

After

image

Test methodology

  • manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Feb 3, 2025
@RussKie
Copy link
Member

RussKie commented Feb 7, 2025

I asked about this in the original changeset. Having controls cross container boundaries is a bad idea.

@mstv mstv merged commit 8288429 into gitextensions:master Feb 10, 2025
4 checks passed
@mstv mstv deleted the fix/output_panel branch February 10, 2025 20:50
@mstv mstv added this to the v5.3 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants