Skip to content

Conversation

gerhardol
Copy link
Member

@gerhardol gerhardol commented Jan 19, 2025

Proposed changes

Remove the native Win override to use "explorer" theme, part of #4491.
This seem to affect the TreeView selected item.
(ListView already changed).

Note: If this is not merged, the winow theme must be set to "DarkMode_Explorer" in dark mode.

Screenshots

Before

image

inactive selected in FileStatus
image

Unchanged below

Not in focus
image

image

with #12116
image
image

After

image

image

Test methodology

Visual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0

I see the indication of the focused node as a useful feature. But it is not very important for me.

image

@gerhardol
Copy link
Member Author

I see the indication of the focused node as a useful feature. But it is not very important for me.

That is there in your PR, not in master.

I like the "explorer" selection style better than GE and left tree is still slightly different from e.g. file status list and the grid but this is slightly more uniform.
Or do I miss something?

Remove the native Win override to use "explorer" theme,
part of gitextensions#4491.
This seem to affect the TreeView selected item.
(ListView already changed).
@gerhardol gerhardol force-pushed the feature/treeview-selection branch from ea1402c to 10401fd Compare February 20, 2025 21:53
@gerhardol
Copy link
Member Author

gerhardol commented Feb 20, 2025

If this is not accepted, I can deactivate this in dark mode only

@RussKie
Copy link
Member

RussKie commented Feb 21, 2025

I disagree with removing "Explorer" theming, that keeps the app "native" looking. For the dark theme should be used (i.e., "DarkMode_Explorer"). This is how its done in Windows Forms runtime, I believe.

@gerhardol
Copy link
Member Author

I disagree with removing "Explorer" theming, that keeps the app "native" looking. For the dark theme should be used (i.e., "DarkMode_Explorer"). This is how its done in Windows Forms runtime, I believe.

The only change I saw was that the selection in the left panel changed slightly, it is still different from selection in filestatus/grid.
I do not recall right now if using "darkmode_explorer" made any changes at all.
It took some time for me to find why dark mode was did not theme (like light scrollbars) so I suggest that the "winforms" mode is used (that should use a similar setup as explorer, but supposedly not for every detail).

To align selection style left panel to the rest of the app is a slightly separate issue. if "explorer" style is kept, the "explorer" style selection could be emulated.

But if the request is to keep the selection style in the left panel for now, then this PR will be declined.
The change in dark mode PR will be to either use darkmode_explorer or just apply the style with light mode (I intend to have a minimal of changes to the default mode in that PR).

@gerhardol gerhardol marked this pull request as draft February 21, 2025 20:23
@gerhardol
Copy link
Member Author

Pushed an update to #12111 to revert this for light mode only (no difference for dark mode what I see).
So this is probably not needed.
Setting to draft but will close if the consensus is that left panel should be kept as is
(but the selection should be aligned)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants