-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Remove TreeView "explorer" style #12150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove TreeView "explorer" style #12150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is there in your PR, not in master. I like the "explorer" selection style better than GE and left tree is still slightly different from e.g. file status list and the grid but this is slightly more uniform. |
Remove the native Win override to use "explorer" theme, part of gitextensions#4491. This seem to affect the TreeView selected item. (ListView already changed).
ea1402c
to
10401fd
Compare
If this is not accepted, I can deactivate this in dark mode only |
I disagree with removing "Explorer" theming, that keeps the app "native" looking. For the dark theme should be used (i.e., "DarkMode_Explorer"). This is how its done in Windows Forms runtime, I believe. |
The only change I saw was that the selection in the left panel changed slightly, it is still different from selection in filestatus/grid. To align selection style left panel to the rest of the app is a slightly separate issue. if "explorer" style is kept, the "explorer" style selection could be emulated. But if the request is to keep the selection style in the left panel for now, then this PR will be declined. |
Pushed an update to #12111 to revert this for light mode only (no difference for dark mode what I see). |
Proposed changes
Remove the native Win override to use "explorer" theme, part of #4491.
This seem to affect the TreeView selected item.
(ListView already changed).
Note: If this is not merged, the winow theme must be set to "DarkMode_Explorer" in dark mode.
Screenshots
Before
inactive selected in FileStatus

Unchanged below
Not in focus

with #12116


After
Test methodology
Visual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.