test(ExecutableTests): Relax timeout for slow AppVeyor #12141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for slow AppVeyor
gerhardol
approved these changes
Jan 16, 2025
| @@ -55,7 +55,7 @@ public async Task Process_shall_be_killed_on_cancellation() | |||
| process.Dispose(); | |||
|
|
|||
| TimeSpan durationWaitTimeout = DateTime.Now - startedAt; | |||
| durationWaitTimeout.Should().BeGreaterThan(1.5 * cancelDelay).And.BeLessThan(2.5 * cancelDelay); | |||
| durationWaitTimeout.Should().BeGreaterThan(1.5 * cancelDelay).And.BeLessThan(4 * cancelDelay); | |||
There was a problem hiding this comment.
Is 4 enough, why not 10 or so?
There was a problem hiding this comment.
Is 4 enough, why not 10 or so?
Most of the time, the testcase passed within the original 2.5 seconds. Worst case was ~ 3.5 seconds.
The process shall be killed in reasonable time. I want to be notified if this does not work well.
RussKie
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Several CI builds failed because the testcase execution on AppVeyor took more than 3 seconds.
Relax the regarding timer.
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.