fix: InactiveSelectionHighlight in theme #12133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Jan 7, 2025
mstv
approved these changes
Jan 7, 2025
Add hardcoded colors InactiveSelectionHighlight and NonRelativeColor to themeable colors.
mstv
approved these changes
Jan 7, 2025
mstv
reviewed
Jan 8, 2025
Add hardcoded colors InactiveSelectionHighlight and NonRelativeColor to themeable colors.
mstv
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change OtherColors.InactiveSelectionHighlightColor to a themeable color.
It requires tweaking for dark mode.
This PR has no change for the default theme.
Test methodology
Review/Visual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.