fix(theme): Remove unused hook methods #12127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the EasyHook handling that was required for theming in GE v3.x with .NET framework v4. This solution has has not worked since GE v4, that use .NET core (.net6 and later). .net9 has experimental support for dark mode that can enable the use of dark mode. The activation of hooking was disabled by the define SUPPORT_THEME_HOOKS. A number of unused methods was used too, as well as the EasyHooks submodule. The .net9 solution do not allow customization of system colors, so overrides were removed from the themes. As the darksilver theme mostly changed system colors, it was removed. The invariant theme system colors is required by theming to adjust colors and still requires the system colors. The color for MenuHighlight was corrected in the invaiant theme. ButtonFace, ButtonHighlight, ButtonShadow was assumed to be duplicates of Control* colors, this was not corrrect and the handling was removed. The workaround for dark header was removed too.
RussKie
approved these changes
Jan 4, 2025
mstv
approved these changes
Jan 4, 2025
Default (invariant, what is in the code) is used if the theme cannot be loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the no longer working hooking preparing for #12111
This should have no effect on the invariant theme in v5.
Proposed changes
Remove the EasyHook handling that was required for theming in GE v3.x with .NET framework v4. This solution has has not worked since GE v4, that use .NET core (.net6 and later). .net9 has experimental support for dark mode that can enable the use of dark mode.
The activation of hooking was disabled by the define SUPPORT_THEME_HOOKS. A number of unused methods was used too,
as well as the EasyHooks submodule.
The .net9 solution do not allow customization of system colors, so overrides were removed from the themes.
As the darksilver theme mostly changed system colors, it was removed.
The invariant theme system colors is required by theming to adjust colors and still requires the system colors.
The color for MenuHighlight was corrected in the invaiant theme. ButtonFace, ButtonHighlight, ButtonShadow was assumed to be duplicates of Control* colors, this was not corrrect and the handling was removed.
The workaround for dark header was removed too.
Test methodology
Visual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.