fix: Adapt hardcoded colors #12125
fix: Adapt hardcoded colors #12125
Conversation
src/app/GitUI/UserControls/RevisionGrid/Columns/BuildStatusColumnProvider.cs
Outdated
Show resolved
Hide resolved
src/app/GitUI/UserControls/RevisionGrid/Columns/MessageColumnProvider.cs
Outdated
Show resolved
Hide resolved
src/app/GitUI/UserControls/RevisionGrid/Graph/RevisionGraphLaneColor.cs
Outdated
Show resolved
Hide resolved
src/app/GitUI/UserControls/RevisionGrid/Graph/RevisionGraphLaneColor.cs
Outdated
Show resolved
Hide resolved
Do we have anything for a .1 release? |
| { 'e', ("edit", new HighlightColor(Color.DarkGray.AdaptTextColor(), bold: true, italic: false), Array.Empty<string>()) }, | ||
| { 's', ("squash", new HighlightColor(Color.DarkBlue.AdaptTextColor(), bold: true, italic: false), Array.Empty<string>()) }, | ||
| { 'f', ("fixup", new HighlightColor(Color.LightCoral.AdaptTextColor(), bold: true, italic: false), new[] { "-C", "-c" }) }, | ||
| { 'x', ("exec", new HighlightColor(SystemColors.GrayText, bold: true, italic: false), Array.Empty<string>()) }, |
There was a problem hiding this comment.
Note: This changes the color very slightly for the default theme.
I meant we should release a v5.2 with the bug fixes #12122 & #12129 and, optionally, with the low-risk feature #12023 (used for several months; and we have a fallback: the much slower ConEmu). I would appreciate a soon release of v5.2. Then we could switch to .NET 9 and merge the fresh features (theming, tree view) and let them mature and be extended. |
|
I'm away until the end of Jan and only have a mac, but I can try to muster a release. |
I believe a 5.2 should be done soon, many nice corrections by mstv lately. The changes I have in non draft for themeing should all have no effect on the default theme (I hope I have described all, forgot to mention src/app/GitUI/Editor/RebaseTodoHighlightingStrategy.cs) I would like to merge the preparing PRs together so the actual changes for the theme are minimized and discussions can be on actual issues. |
Prepare for theming by adapting hardcoded colors to theme colors. Some colors set in Designer updated in the forms.
a45938e to
2184655
Compare
Preparation for #12111
Simplify review of the theme update.
This PR does not change behavior for the invariant theme.
There may be tweaks required to the theme handling in #12111 when that is actively reviewed, that review should be based on this (and similar) PRs.
Will likely be merged together with similar preparing PRs.
Proposed changes
Prepare for theming by adopting hardcoded colors to theme colors.
Some colors set in Designer updated in the form code files.
Requested in the theme PR, make it harder to review this PR.
#12111 (comment)
Test methodology
Review
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.