fix(WindowPositionManager): Add vertical heuristic #12119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Jan 2, 2025
gerhardol
approved these changes
Jan 2, 2025
|
I moved FormCommit to the secondary screen (4K with scaling of 150%) at the right of the primary screen (2K 100%) and maximized it. Close and re-open restored the maximized state but on the primary screen. |
|
The core underlying issue only surfaces when monitors run at different dpi. Because the app is run as "system aware", it's unable to scale windows correctly opened on the second monitor (being primary or secondary). The new windows are being opened with the dpi of the monitor where the parent window resides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11589 for maximized FormCommit
Proposed changes
WindowPositionManager:Screenshots
N/A
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.