feat: SystemColors.Window in Dashboard theme #12118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Jan 2, 2025
|
I think that, ultimately, DashboardTheme should be retired completely. Instead, we should use SystemColors. |
That was my first intention. I updated the screenshots with how it would look like with a similar setup as proposed for the dark theme. |
Use SystemColors.Window for dashboard background theme, to be consistent with the normal app. Prepare the dark theme to be consistent with the app. The dark colors are not using the blue colors of the default light theme but greyish colors.
e1198d9 to
671aa12
Compare
Merged
|
For future changes with this Form it might be worth considering removing the background image and having just a solid color. On 4K screens this form is taking a noticeable time to load due to the background. I have it removed on my personal build and the repo lists opens noticeably faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use SystemColors.Window for dashboard background theme, to be consistent with the normal app.
Some renaming to clarify color usage
Prepare the dark theme to be consistent with the app. The dark colors are not using the blue colors of the default light theme but greyish colors.
The theme does not look better, but is consistent with the .net9 dark mode (that cannot be tweaked much).
Screenshots
Recent repo background and searchbox background swapped.
Alternative light theme with system colors as for the dark theme
Note that the second header cannot be changed in the darktheme in .net9 (unless ListView is replaced)
Test methodology
Visual
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.