-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Support saving LFS files #12078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How can you see if a file is lfs now? Save as may be useful for some, sure. Diff and view is not interesting for me, these files are binary or very large normally, it is just to get something that seem complete. |
What is missing for you? LFS file added:
LFS file changed: (looks the same regardless of the heuristic for binary files) Large text files
New LFS file looks the same for "Index" and real commit If really in doubt, there is a mix of related LFS commands:
It was useless and rather a bug because of its unexpected behavior. (It transparently works for difftool. Why not for "Save as" and for displaying the picture of the |
A missing separate feature is to provide a context menu item for |
To see if a file is handled by lfs or not. This can be done in other ways, maybe in the context menu. and my opinions is probably the important here, this is plugging something that users see as a problem (but it is not really that). |
You need to run |
This PR is about getting / saving selected files. Refer to the issue being fixed, please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, quick review
Simplify peeking the stream
Async orgy
Adapt to IProcess.StandardError
I am not thrilled to not see if the image file is handled or not, but approving. |
review comment
Fixes #6146
Finishes #6189
Proposed changes
Screenshots
Before
After
Test methodology
with LFS-pointer-like files
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.