Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Nov 28, 2024

Fixes #12072 (comment) in all other occurrences

Proposed changes

  • MemoryStream: Add missing using statement
  • Remove unnecessary stream copy from FileViewer.CreateImage

Screenshots

N/A

Test methodology

  • existing tests
  • manually (view .ico and .png file of GE repo in diff and as new file)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

Remove unnecessary stream copy from FileViewer.CreateImage
@mstv mstv self-assigned this Nov 28, 2024
@mstv mstv merged commit c61e8ed into gitextensions:master Nov 28, 2024
4 checks passed
@mstv mstv deleted the fix/memory_stream branch November 28, 2024 20:47
@mstv mstv added this to the v5.2 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants