Skip to content

feat(CI/ADO): Add support for pull requests #12029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2024
Merged

feat(CI/ADO): Add support for pull requests #12029

merged 3 commits into from
Nov 15, 2024

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Nov 7, 2024 •
edited
Loading

Proposed changes

  • Display Azure DevOps PRs builds result in commit built (pipeline is building a merge commit
    and so it is a little more tricky to get the original hash of the commit built)
  • Add support to open Pull Request page from contextual menu
  • improve a little the tooltip (to have all the information on one line --and prepare display of multiple build result in the tooltip--)
    • display also PR id and build name

Screenshots

Before

  • The result for the PR is not available
    image

After

  • Build result on the commit & Tooltip (with PR information)
    image

  • Open the PR
    image

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 5a7e3d88ee69ac359c3dcba8160c607959f85c97 (Dirty)
  • Git 2.45.0.windows.1 (recommended: 2.46.0 or later)
  • Microsoft Windows NT 10.0.22631.0
  • .NET 8.0.8
  • DPI 96dpi (no scaling)
  • Portable: False
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.31 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Merge strategy

I agree that the maintainer do what they want with this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

gerhardol
gerhardol reviewed Nov 9, 2024
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for Azure DevOps, should have been explained in the description....
No comments on the implementation, very brief review.

@RussKie
Copy link
Member

RussKie commented Nov 14, 2024

I'd love to have the ability to see builds for all pipelines configured in a repo. E.g., dotnet repos have a public and an internal pipeline, and right now only it's only possible to see build status the first configured pipeline.

@pmiossec
refactor: DRY, follow SonarLint advices
fcd4755
@pmiossec
ADO: Better one line build result tooltip
bc3bac0 
with Build name displayed
@pmiossec
feat(CI/ADO): Add support for Pull Request builds
d4955b4 
that builds a merge commit
and so it is a little more tricky to get the original hash of the commit built
+ Add support to open Pull Request page from contextual menu
@pmiossec
Copy link
Member Author

I'd love to have the ability to see builds for all pipelines configured in a repo. E.g., dotnet repos have a public and an internal pipeline, and right now only it's only possible to see build status the first configured pipeline.

At the moment, you can configure it so that it get the results for all the pipelines but it indeed, only the last build status is displayed.
I have made a beginning of improvement on that years ago and will try to finish it now that I use ADO pipeline again (and that I could test it more easily)

@pmiossec pmiossec merged commit f1fb7c3 into gitextensions:master Nov 15, 2024
4 checks passed
@pmiossec pmiossec deleted the feat/adp_pr_builds branch November 15, 2024 08:31
@mstv mstv added this to the v5.2 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol left review comments

@RussKie RussKie RussKie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@pmiossec @RussKie @gerhardol @mstv