Skip to content

Conversation

gerhardol
Copy link
Member

@gerhardol gerhardol commented Oct 14, 2024

Proposed changes

instead of inserting '|' to the text

Screenshots

Before

5.0.0
Highlight colors is here normal/bold, changed to dim/bold in master

image

After

image

Test methodology

test for the divider added

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@gerhardol gerhardol marked this pull request as draft October 14, 2024 21:13
instead of inserting '|' to the text
@gerhardol gerhardol force-pushed the feature/grep-splitter branch from 2546635 to ff6267a Compare October 19, 2024 19:46
@gerhardol gerhardol marked this pull request as ready for review October 19, 2024 19:47
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have not run

@gerhardol
Copy link
Member Author

Merging this in #11983 instead
There is a problem with removing the gap in this PR, the handling is too complicated to fix.

@gerhardol gerhardol closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants