feat: Cache the diff highlighting #11981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9cf606 to
c79e925
Compare
Cache the diff markings, only calculate when a file is added, not everytime marking is changed in the file. This was already the case for diff coloring by Git, but not by the (simpler) GE engine. The caching also applies to the inline difference calculations, to dim part of lines that are unchanged.
46c800b to
5e31f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11947
Proposed changes
Split in two commits for review:
Before this processing was done every time a marker was changed in the diff viewer.
(before #11947 the complete text was parsed every time too)
Test methodology
Refactoring only, tests exists
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.