fix: commit gpgSign Git defaults #11963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dialogue "Do not sign commit" should explititly not set GPG key. The default is set to "Git default", using the git-config settings.
mstv
reviewed
Oct 6, 2024
mstv
approved these changes
Oct 6, 2024
RussKie
approved these changes
Oct 7, 2024
|
Rephrased the text for the first option |
mstv
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11931
Proposed changes
Commit dialogue "Do not sign commit" should explicitly not set GPG key.
The default is set to "Git default", using the git-config settings.
Screenshots
Adding the first option in the dropdown
Test methodology
tests updated
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.