feat(settings): deeper checks for GitExtensions install directory #11913
Conversation
* Check that the folder exists * Check that it is set to the currently running instance GE install path Make GE config more reliable. Related to gitextensions/gitextensions.vsix#33 (comment)
| @@ -530,7 +530,13 @@ private bool CheckGitExtensionsInstall() | |||
| return false; | |||
| } | |||
|
|
|||
| if (installDir.EndsWith(".exe")) | |||
| if (installDir.EndsWith(".exe") || !Directory.Exists(installDir)) | |||
There was a problem hiding this comment.
It'd be great to have some comments here explaining the checks.
There was a problem hiding this comment.
Also, how would the user correct the incorrect setting?
There was a problem hiding this comment.
There was a problem hiding this comment.
The referenced message suggests the user will have to reinstall the app...
What happens when the user clicks on the "blue" row?
There was a problem hiding this comment.
The Repair button is missing in the screenshot
There was a problem hiding this comment.
Also, how would the user correct the incorrect setting?
He just has to click on the line or "Repair":
Everything is in place to fix the issue, we just need to improve detection of the problem...
(forgot to sent the comment 2 days again...)
| @@ -530,7 +530,13 @@ private bool CheckGitExtensionsInstall() | |||
| return false; | |||
| } | |||
|
|
|||
| if (installDir.EndsWith(".exe")) | |||
| if (installDir.EndsWith(".exe") || !Directory.Exists(installDir)) | |||
There was a problem hiding this comment.
Make GE config more reliable. Related to gitextensions/gitextensions.vsix#33 (comment)
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.