-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove seconds from commit date display (#11812) #11868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
Although it is just one changed char, we need your sign-off in contributors.txt
, please.
0 I probably prefer the seconds in the grid, but will not vote against this (seconds is still in CommitInfo). |
Personally, I'm not really pleased by this change. On day to day work, I don't need dates and so I hide the column to make more room for other information. But the few times where I show the column, it's to compare dates of different commits and here the seconds are the most important data. Not really blocking because it is rare and maybe I will find another way to achieve the same thing. |
Since there's a discontent, perhaps it's worth making it configurable...
…On Mon, 2 Sept 2024, 7:56 am Philippe Miossec, ***@***.***> wrote:
Personally, I'm not really pleased by this change. On day to day work, I
don't need dates and so I hide the column to make more room for other
information. But the few times where I show the column, it's to compare
dates of different commits and here the seconds are the most important data.
Not really blocking because it is rare and maybe I will find another way
to achieve the same thing.
—
Reply to this email directly, view it on GitHub
<#11868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBTEXTGBI52IGKQ2EF6S53ZUOER5AVCNFSM6AAAAABNOZES42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGUYTANZQHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
No, there are too many configurables already, hard to find |
This can be a hidden config.
But overall I'm indifferent to this change.
…On Mon, 2 Sept 2024, 8:29 pm Gerhard Olsson, ***@***.***> wrote:
Since there's a discontent, perhaps it's worth making it configurable...
No, there are too many configurables already, hard to find
(even if I personally appreciate them)
—
Reply to this email directly, view it on GitHub
<#11868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBTEXRWX52OCZ2QOHQP5A3ZUQ4ZRAVCNFSM6AAAAABNOZES42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGM4DOMZYHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I personally have difficulties to see the consequences of this change and if users will never noticed. Or if we won't have issues created reclaiming to display the seconds, later...
If we want to cut the discussion and merge the change, maybe it's the best solution. If so, I don't know which is the best in this case?
Still interested by this answer even if we don't add one new setting because I had this dilemma multiple times for other settings... |
Hidden config for the format string? |
Also the line 18 gitextensions/src/app/GitUI/UserControls/RevisionGrid/Columns/DateColumnProvider.cs Line 18 in 72cd19f
so maybe we should not use DateTime.Now but an hardcoded carefully chosen value with double digit hours, minutes and seconds). So something looking like:
|
Given the discussion we're already having, I don't think this change is worth the risk and associated complexities, especially since the workaround is easy - make the column narrower to hide the seconds (see #11812 (comment)). |
Based on the discussion, I don’t think I should change this. Can I close the pull request? |
Yes |
Fixes #11812
Proposed changes
YYYY-MM-DD HH:MM:SS
toYYYY-MM-DD HH:MM
.Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.