feat: GitCache: Add current directory to key #11850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Aug 24, 2024
src/app/GitUI/CommandsDialogs/BrowseDialog/FormGitCommandLog.cs
Outdated
Show resolved
Hide resolved
src/app/GitUI/CommandsDialogs/BrowseDialog/FormGitCommandLog.cs
Outdated
Show resolved
Hide resolved
src/app/GitUI/CommandsDialogs/BrowseDialog/FormGitCommandLog.cs
Outdated
Show resolved
Hide resolved
RussKie
approved these changes
Aug 25, 2024
Git cache uses the command as the cache key. However a sha could theoretically be duplicated in repos, so the path is added. (This means that multiple clones (also worktrees) are no longer cached.) Clean escape sequences before storing in the cache to speed up fetching information from the cache. Clean escape is also added to the cache key. Cache DiffTastic commands, add environment variables as cache keys.
28e30da to
37ce0e3
Compare
|
I would like to include this in 5.0 |
mstv
approved these changes
Aug 25, 2024
mstv
reviewed
Aug 25, 2024
Boo... 😒 |
mstv
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11848
Proposed changes
Git cache uses the command as the cache key. However a sha could
theoretically be duplicated in repos, so the path is added.
(This means that multiple clones (like worktrees) are no longer cached.)
Clean escape sequences before storing in the cache to speed up
fetching information from the cache.
Clean escape is also added to the cache key.
Cache DiffTastic commands, add environment variables as cache keys.
--
There is no strong requirement to include this PR in 5.0, but it improves DiffTastic usage in reviews. I switch the different mode several times per file and the delay to open difftastic is annoying.
Test methodology
The cache tests are updated - only the format of what is changed that is changed.
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.