FileViewer: ShowSyntaxHighlighting hotkey and context menu #11530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we sort the context menu items in order to match the sequence of the toolbar? |
I considered that too. Can do it this PR if agreed. |
mstv
reviewed
Jan 17, 2024
* Sort context menu to match the toolbar
mstv
reviewed
Jan 18, 2024
|
|
* Sort context menu to match the toolbar * Mnemonics for context menu * Default hotkey for ShowSyntaxHighlighting and ShowEntireFile
b5f6f1f to
2d289a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hotkey for ShowSyntaxHighlighting to quickly deactivate highlighting in reviews, conflicting with other colors.
Especially useful with #11464 that adds more colors.
Menu item is for completeness and to display current hotkey.
Sorting context menu as toolbar buttons
Mnemonics in context menu
Default hotkey for ShowSyntaxHighlighting and ShowEntireFile
Screenshots
Before
After
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.