GitExtSshAskPass: Ensure chars are outputed as UTF8 chars #11381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because "By default, windows console does not process wide characters." See https://stackoverflow.com/a/15450250/717372 & https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode?view=msvc-170&redirectedfrom=MSDN#example-use-_setmode-to-change-stdout Fixes gitextensions#11379
98e6ba6 to
1c63294
Compare
|
Merging as confirmed to work in #11379 (comment). Thank you @pmiossec! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because "By default, windows console does not process wide characters."
See https://stackoverflow.com/a/15450250/717372
& https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode?view=msvc-170&redirectedfrom=MSDN
Fixes #11379
Test methodology
./GitExtSshAskPass.exefrom git bash (the others consoles don't display outputs or display it wrong!!).\GitExtSshAskPass.exe > output.txtand check file contentTest environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.