Use static Regex in a few more situations #11370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip Compiled regex for a few non static regex That are not expected to be executing extremely often, why interpreted regex is expected to be faster.
mstv
approved these changes
Nov 19, 2023
RussKie
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Skip Compiled regex for a few non static regex
That are not expected to be executing extremely often, why interpreted regex is expected to be faster.
--
A refresh of regex usage according to https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-regex
Most other regex will be compiled in compile time with an upcoming PR for .NEt8 C# 12 (really added in .NET7 C# 11).
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.