Load hotkeys consistently #11330
Merged
Load hotkeys consistently #11330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and from HandleSettingsChanged
Yes, tested successfully. |
pmiossec
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11329
Proposed changes
ReloadHotkeysfromOnRuntimeLoadThere is no need to call it from
OnUICommandsSourceSetbecause the ServiceProvider shall not be exchanged during runtime.In addition,
OnUICommandsSourceSetis not always triggered as necessary.ReloadHotkeysfromFormBrowse.HandleSettingsChangedLoadCustomDifftoolsonly once fromOnRuntimeLoad, tooScreenshots
N/A
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.