Remove RevisionGraphRevision._parents #11314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
Oct 31, 2023
gerhardol
approved these changes
Oct 31, 2023
| @@ -94,7 +94,7 @@ public int EnsureScoreIsAbove(int minimalScore) | |||
|
|
|||
| public ObjectId Objectid { get; } | |||
|
|
|||
| public ImmutableStack<RevisionGraphRevision> Parents => _parents; | |||
| public IEnumerable<RevisionGraphRevision> Parents => _startSegments.Select(segment => segment.Parent); | |||
There was a problem hiding this comment.
_parents is ImmutableStack, _segments is ConcurrentQueue
But revisions are only updated from one thread, so it is probably OK.
ToArray() creates a snapshot, so it issafer.
Reading Parents in BranchFinder is not critical for performance, foreach in EnsureScoreIsAbove() is to some extent.
There is a lock issue still somewhere, why refresh is not running. I just want to avoid more issues...
But approving without requesting changes.
Suggested change
| public IEnumerable<RevisionGraphRevision> Parents => _startSegments.Select(segment => segment.Parent); | |
| public IEnumerable<RevisionGraphRevision> Parents => _startSegments.ToArray().Select(segment => segment.Parent); |
There was a problem hiding this comment.
Who needs the safety of a snapshot, can call
public RevisionGraphSegment[] GetStartSegments() => _startSegments.ToArray();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove redundant field
RevisionGraphRevision._parents, use_startSegmentsinstead.The affected property
Parentsis only used for getting tooltip information and for tests.Screenshots
N/A
Test methodology
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.