Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Oct 29, 2023

Fixes #11273 (comment)
Replaces the undesired #11278

Proposed changes

Trigger the IGitUICommands.RepoChangedNotifier after the execution of scripts and plugins
instead of manually performing updates on CommandStatus.NeedsGridRefresh

Screenshots

N/A

Test methodology

  • existing tests

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@RussKie RussKie added 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity and removed 👓 status: needs review status: ready labels Oct 30, 2023
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Oct 30, 2023
@RussKie RussKie added 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity and removed 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity labels Oct 31, 2023
@mstv mstv merged commit 133d02b into gitextensions:master Oct 31, 2023
@mstv mstv deleted the fix/refresh_after_script branch October 31, 2023 20:58
@ghost ghost added this to the vNext milestone Oct 31, 2023
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I do not realize how this really work but seem to be OK...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants