Skip to content

Conversation

gerhardol
Copy link
Member

@gerhardol gerhardol commented Oct 27, 2023

Fixes #11303

Proposed changes

Symbolic links in WSL cannot be accessed from Windows.
This adds some workarounds that makes it possible to open such repos,
that has been created for instance with Google's repo tool.

All access from Windows will fail, only access by WSL native like "wsl git" works.
At least the following do not work:

  • Display of branch names for (mostly using .git/HEAD to get the name). wsl git can be used here.
  • Git commands using Windows Git (like difftool from submenu with all tools) will fail. (Even listing of tools fail, for instance when closing settings).
  • GE Settings cannot be read/write to local repo
  • Commands using the local .git config will not work. This includes Commit, rebase etc

You can still view information and compare branches though
All issues will likely not be resolved, unless the filesystem in WSL is updated

I doubt linked git repos will be a common use for GE, so there should not be too many complaints.
WSL support in general is a hack.

Test methodology

Manual - basically impossible to test the actual problem

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Oct 27, 2023
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 have not run

@gerhardol gerhardol force-pushed the feature/i11303-wsl-links branch from 535637a to ad5b83c Compare October 28, 2023 22:05
@gerhardol gerhardol marked this pull request as ready for review October 28, 2023 22:31
@gerhardol gerhardol force-pushed the feature/i11303-wsl-links branch from ad5b83c to de6d41b Compare October 28, 2023 23:08
@gerhardol
Copy link
Member Author

Cleaned up the solution, documented the limitations somehow.

@RussKie RussKie merged commit 04c7dae into gitextensions:master Oct 29, 2023
@ghost ghost added this to the vNext milestone Oct 29, 2023
@gerhardol gerhardol deleted the feature/i11303-wsl-links branch October 29, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a repository created by Google's Repo tool in WSL v2 on Windows causes exception
3 participants