Skip to content

Make SubmoduleStatusProvider DI-friendly #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

Make SubmoduleStatusProvider DI-friendly #11271

merged 1 commit into from
Oct 15, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Oct 14, 2023

Remove the static singleton and access SubmoduleStatusProvider via the DI

@ghost ghost assigned RussKie Oct 14, 2023
mstv
mstv approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run

gerhardol
gerhardol reviewed Oct 14, 2023
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Have not run

@RussKie RussKie merged commit 4eae184 into gitextensions:master Oct 15, 2023
@RussKie RussKie deleted the ISubmoduleStatusProvider branch October 15, 2023 02:11
@ghost ghost added this to the vNext milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol left review comments

@mstv mstv mstv approved these changes

Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @gerhardol @mstv