Skip to content

Conversation

mstv
Copy link
Member

@mstv mstv commented Oct 16, 2023

Fixes #11273 (comment)

Proposed changes

  • Replace CommandStatus with bool (meaning Executed) because the only other property NeedsGridRefresh has become obsolete

Screenshots

N/A

Test methodology

  • existing tests

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Oct 16, 2023
@mstv mstv marked this pull request as draft October 16, 2023 21:34
@mstv

This comment was marked as outdated.

Copy link
Contributor

@SlugFiller SlugFiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

Copy link
Contributor

@SlugFiller SlugFiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have gone over all the files before submitting the previous one.

@mstv mstv force-pushed the feature/remove_command_status branch 2 times, most recently from 8ed587d to 8d84d59 Compare October 19, 2023 18:38
@mstv mstv force-pushed the feature/remove_command_status branch from 8d84d59 to 6045ff7 Compare October 29, 2023 16:37
because .NeedsGridRefresh has become obsolete
@mstv mstv marked this pull request as ready for review October 31, 2023 21:04
@mstv mstv force-pushed the feature/remove_command_status branch from 6045ff7 to 46be1a1 Compare October 31, 2023 21:04
@mstv mstv merged commit 28648b1 into gitextensions:master Nov 1, 2023
@mstv mstv deleted the feature/remove_command_status branch November 1, 2023 20:32
@ghost ghost added this to the vNext milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants